Vendored spectre-css to update its scss syntax around colors and math #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This swaps out deprecated sass functions and syntax for their modern counterparts.
Why it is important
The times are a-changin' and so must we.
UI Change Screenshot
An example of the deprecation message:
Implementation notes
Sass has a migration tool for these changes that I ran on the affected files. The TL;DR of these changes is that
darken,lighten, and using/for division are all deprecated.This PR looks super huge and it kind of is. Our primary css framework (Spectre CSS) hasn't had an update in about 4 years and deprecation warnings in the package were showing up in our build process. I copied the main scss code from the repo into our
app/assetsand ran the migration tool on those.This is kind of a short term fix to get rid of some noise. Longer term, we should migrate off of Spectre to something else (I've added an issue for this).